summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLinus Walleij <linus.walleij@linaro.org>2015-12-22 15:41:01 +0100
committerRalf Baechle <ralf@linux-mips.org>2016-01-24 02:22:14 +0100
commit6ea6b7faf0fbc7f2bb55277befe478c0a66659fc (patch)
tree24664d60cb1af8b4e268c5e840c108bc24e2fe67
parent249e573d99ab590e19bd23f084f8c6540daa7b06 (diff)
downloadop-kernel-dev-6ea6b7faf0fbc7f2bb55277befe478c0a66659fc.zip
op-kernel-dev-6ea6b7faf0fbc7f2bb55277befe478c0a66659fc.tar.gz
MIPS: TXx9: Be sure to clamp return value
As we want gpio_chip .get() calls to be able to return negative error codes and propagate to drivers, we need to go over all drivers and make sure their return values are clamped to [0,1]. We do this by using the ret = !!(val) design pattern. Signed-off-by: Linus Walleij <linus.walleij@linaro.org> Cc: linux-mips@linux-mips.org Cc: linux-gpio@vger.kernel.org Patchwork: https://patchwork.linux-mips.org/patch/11923/ Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
-rw-r--r--arch/mips/kernel/gpio_txx9.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/mips/kernel/gpio_txx9.c b/arch/mips/kernel/gpio_txx9.c
index c6854d9..705be43c 100644
--- a/arch/mips/kernel/gpio_txx9.c
+++ b/arch/mips/kernel/gpio_txx9.c
@@ -21,7 +21,7 @@ static struct txx9_pio_reg __iomem *txx9_pioptr;
static int txx9_gpio_get(struct gpio_chip *chip, unsigned int offset)
{
- return __raw_readl(&txx9_pioptr->din) & (1 << offset);
+ return !!(__raw_readl(&txx9_pioptr->din) & (1 << offset));
}
static void txx9_gpio_set_raw(unsigned int offset, int value)
OpenPOWER on IntegriCloud