summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorTomas Winkler <tomas.winkler@intel.com>2013-09-04 15:35:52 +0300
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2013-09-26 08:44:40 -0700
commit6d3e0d0c1ca926fd6ab557fcd5efb171148f43d6 (patch)
tree6177acff20ec3617a5de3cfee4ad39722261f7d9
parentd396034aa860e7aaade347a535e831a4307037d3 (diff)
downloadop-kernel-dev-6d3e0d0c1ca926fd6ab557fcd5efb171148f43d6.zip
op-kernel-dev-6d3e0d0c1ca926fd6ab557fcd5efb171148f43d6.tar.gz
hpet: remove useless check if fixmem32 is NULL
fixmem32 is assigned to address of res->data member so the address is always valid Actually since we are not checking for res != NULL static analyzing is complaining about referencing the pointer and consequent check for null. The code snippet looks confusing also for human eyes. Cc: Randy Dunlap <rdunlap@infradead.org> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/char/hpet.c2
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/char/hpet.c b/drivers/char/hpet.c
index 448ce5e..c8f4329 100644
--- a/drivers/char/hpet.c
+++ b/drivers/char/hpet.c
@@ -971,8 +971,6 @@ static acpi_status hpet_resources(struct acpi_resource *res, void *data)
struct acpi_resource_fixed_memory32 *fixmem32;
fixmem32 = &res->data.fixed_memory32;
- if (!fixmem32)
- return AE_NO_MEMORY;
hdp->hd_phys_address = fixmem32->address;
hdp->hd_address = ioremap(fixmem32->address,
OpenPOWER on IntegriCloud