summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJohan Hovold <johan@kernel.org>2016-11-08 13:24:55 +0100
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2016-11-10 14:41:25 +0100
commit68832b20c92affcbe739ff1f6343516d8b824223 (patch)
tree5c1e6c014979195c48a1a14f576cbdab79aa676a
parent7a3f09846c978e613979d89f99b633b501f202a2 (diff)
downloadop-kernel-dev-68832b20c92affcbe739ff1f6343516d8b824223.zip
op-kernel-dev-68832b20c92affcbe739ff1f6343516d8b824223.tar.gz
serial: crisv10: fix invalid user-pointer check
Drop invalid user-pointer check from TIOCGSERIAL handler. A NULL-pointer can be valid in user space and copy_to_user() takes care of sanity checking. Cc: Mikael Starvik <starvik@axis.com> Cc: linux-cris-kernel@axis.com Signed-off-by: Johan Hovold <johan@kernel.org> Acked-by: Jesper Nilsson <jesper.nilsson@axis.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/tty/serial/crisv10.c2
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/tty/serial/crisv10.c b/drivers/tty/serial/crisv10.c
index 6450a38..e92c234 100644
--- a/drivers/tty/serial/crisv10.c
+++ b/drivers/tty/serial/crisv10.c
@@ -3213,8 +3213,6 @@ get_serial_info(struct e100_serial * info,
* should set them to something else than 0.
*/
- if (!retinfo)
- return -EFAULT;
memset(&tmp, 0, sizeof(tmp));
tmp.type = info->type;
tmp.line = info->line;
OpenPOWER on IntegriCloud