summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorNamhyung Kim <namhyung.kim@lge.com>2012-11-29 15:38:34 +0900
committerArnaldo Carvalho de Melo <acme@redhat.com>2012-12-09 08:46:06 -0300
commit5fa9041bbaa7a79a67d568b9c9f947db2f23d091 (patch)
tree8c60f9961f046c73eb1c5992d384b20a4deddc2a
parent2850d9487266a55a18d340c24f5107696deeebb9 (diff)
downloadop-kernel-dev-5fa9041bbaa7a79a67d568b9c9f947db2f23d091.zip
op-kernel-dev-5fa9041bbaa7a79a67d568b9c9f947db2f23d091.tar.gz
perf hists: Link hist entry pairs to leader
Current hists__match/link() link a leader to its pair, so if multiple pairs were linked, the leader will lose pointer to previous pairs since it was overwritten. Fix it by making leader the list head. Signed-off-by: Namhyung Kim <namhyung@kernel.org> Cc: Andi Kleen <andi@firstfloor.org> Cc: Ingo Molnar <mingo@kernel.org> Cc: Jiri Olsa <jolsa@redhat.com> Cc: Paul Mackerras <paulus@samba.org> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl> Cc: Stephane Eranian <eranian@google.com> Link: http://lkml.kernel.org/r/1354171126-14387-8-git-send-email-namhyung@kernel.org Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
-rw-r--r--tools/perf/util/hist.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/tools/perf/util/hist.c b/tools/perf/util/hist.c
index d2bc05c..82df1b2 100644
--- a/tools/perf/util/hist.c
+++ b/tools/perf/util/hist.c
@@ -785,7 +785,7 @@ void hists__match(struct hists *leader, struct hists *other)
pair = hists__find_entry(other, pos);
if (pair)
- hist_entry__add_pair(pos, pair);
+ hist_entry__add_pair(pair, pos);
}
}
@@ -806,7 +806,7 @@ int hists__link(struct hists *leader, struct hists *other)
pair = hists__add_dummy_entry(leader, pos);
if (pair == NULL)
return -1;
- hist_entry__add_pair(pair, pos);
+ hist_entry__add_pair(pos, pair);
}
}
OpenPOWER on IntegriCloud