diff options
| author | Trond Myklebust <trond.myklebust@primarydata.com> | 2015-09-04 15:07:37 -0400 |
|---|---|---|
| committer | Trond Myklebust <trond.myklebust@primarydata.com> | 2015-09-04 16:54:28 -0400 |
| commit | 5cf9d70659594e1a75b34d18619d0bb6e0cbbafa (patch) | |
| tree | e0867951fda1530a1ca2099c4a3f1e4e7f0b0df9 | |
| parent | 7cc8c5cde0a5872f5d013f82978b73c011d8f8f1 (diff) | |
| download | op-kernel-dev-5cf9d70659594e1a75b34d18619d0bb6e0cbbafa.zip op-kernel-dev-5cf9d70659594e1a75b34d18619d0bb6e0cbbafa.tar.gz | |
NFS: Optimise away the close-to-open getattr if there is no cached data
If there is no cached data, then there is no need to track the file
change attribute on close.
Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com>
| -rw-r--r-- | fs/nfs/inode.c | 13 |
1 files changed, 10 insertions, 3 deletions
diff --git a/fs/nfs/inode.c b/fs/nfs/inode.c index 99a68bd..6307d8d 100644 --- a/fs/nfs/inode.c +++ b/fs/nfs/inode.c @@ -761,11 +761,13 @@ EXPORT_SYMBOL_GPL(nfs_put_lock_context); * @ctx: pointer to context * @is_sync: is this a synchronous close * - * always ensure that the attributes are up to date if we're mounted - * with close-to-open semantics + * Ensure that the attributes are up to date if we're mounted + * with close-to-open semantics and we have cached data that will + * need to be revalidated on open. */ void nfs_close_context(struct nfs_open_context *ctx, int is_sync) { + struct nfs_inode *nfsi; struct inode *inode; struct nfs_server *server; @@ -774,7 +776,12 @@ void nfs_close_context(struct nfs_open_context *ctx, int is_sync) if (!is_sync) return; inode = d_inode(ctx->dentry); - if (!list_empty(&NFS_I(inode)->open_files)) + nfsi = NFS_I(inode); + if (inode->i_mapping->nrpages == 0) + return; + if (nfsi->cache_validity & NFS_INO_INVALID_DATA) + return; + if (!list_empty(&nfsi->open_files)) return; server = NFS_SERVER(inode); if (server->flags & NFS_MOUNT_NOCTO) |
