summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorCatalin Marinas <catalin.marinas@arm.com>2013-07-19 15:08:15 +0100
committerCatalin Marinas <catalin.marinas@arm.com>2013-07-19 15:49:42 +0100
commit53ae3acd4390ffeecb3a11dbd5be347b5a3d98f2 (patch)
treeddea9b72c31a91d658eee33f54ac602a342b3687
parentad81f0545ef01ea651886dddac4bef6cec930092 (diff)
downloadop-kernel-dev-53ae3acd4390ffeecb3a11dbd5be347b5a3d98f2.zip
op-kernel-dev-53ae3acd4390ffeecb3a11dbd5be347b5a3d98f2.tar.gz
arm64: Only enable local interrupts after the CPU is marked online
There is a slight chance that (timer) interrupts are triggered before a secondary CPU has been marked online with implications on softirq thread affinity. Signed-off-by: Catalin Marinas <catalin.marinas@arm.com> Reported-by: Kirill Tkhai <tkhai@yandex.ru>
-rw-r--r--arch/arm64/kernel/smp.c15
1 files changed, 8 insertions, 7 deletions
diff --git a/arch/arm64/kernel/smp.c b/arch/arm64/kernel/smp.c
index 5d54e37..9c93e12 100644
--- a/arch/arm64/kernel/smp.c
+++ b/arch/arm64/kernel/smp.c
@@ -200,13 +200,6 @@ asmlinkage void __cpuinit secondary_start_kernel(void)
raw_spin_unlock(&boot_lock);
/*
- * Enable local interrupts.
- */
- notify_cpu_starting(cpu);
- local_irq_enable();
- local_fiq_enable();
-
- /*
* OK, now it's safe to let the boot CPU continue. Wait for
* the CPU migration code to notice that the CPU is online
* before we continue.
@@ -215,6 +208,14 @@ asmlinkage void __cpuinit secondary_start_kernel(void)
complete(&cpu_running);
/*
+ * Enable GIC and timers.
+ */
+ notify_cpu_starting(cpu);
+
+ local_irq_enable();
+ local_fiq_enable();
+
+ /*
* OK, it's off to the idle thread for us
*/
cpu_startup_entry(CPUHP_ONLINE);
OpenPOWER on IntegriCloud