diff options
| author | Alan Stern <stern@rowland.harvard.edu> | 2013-03-15 14:02:14 -0400 |
|---|---|---|
| committer | Felipe Balbi <balbi@ti.com> | 2013-03-20 16:46:33 +0200 |
| commit | 511f3c5326eabe1ece35202a404c24c0aeacc246 (patch) | |
| tree | d8ccc58cefff899c37ae0854b76c4e3ff467aa56 | |
| parent | 699412d951e6dd4dec48db88f33dc27b361582f0 (diff) | |
| download | op-kernel-dev-511f3c5326eabe1ece35202a404c24c0aeacc246.zip op-kernel-dev-511f3c5326eabe1ece35202a404c24c0aeacc246.tar.gz | |
usb: gadget: udc-core: fix a regression during gadget driver unbinding
This patch (as1666) fixes a regression in the UDC core. The core
takes care of unbinding gadget drivers, and it does the unbinding
before telling the UDC driver to turn off the controller hardware.
When the call to the udc_stop callback is made, the gadget no longer
has a driver. The callback routine should not be invoked with a
pointer to the old driver; doing so can cause problems (such as
use-after-free accesses in net2280).
This patch should be applied, with appropriate context changes, to all
the stable kernels going back to 3.1.
Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
CC: <stable@vger.kernel.org>
Signed-off-by: Felipe Balbi <balbi@ti.com>
| -rw-r--r-- | drivers/usb/gadget/udc-core.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/usb/gadget/udc-core.c b/drivers/usb/gadget/udc-core.c index 2a9cd36..f8f62c3 100644 --- a/drivers/usb/gadget/udc-core.c +++ b/drivers/usb/gadget/udc-core.c @@ -216,7 +216,7 @@ static void usb_gadget_remove_driver(struct usb_udc *udc) usb_gadget_disconnect(udc->gadget); udc->driver->disconnect(udc->gadget); udc->driver->unbind(udc->gadget); - usb_gadget_udc_stop(udc->gadget, udc->driver); + usb_gadget_udc_stop(udc->gadget, NULL); udc->driver = NULL; udc->dev.driver = NULL; |
