summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMonk Liu <Monk.Liu@amd.com>2017-05-11 13:59:15 +0800
committerAlex Deucher <alexander.deucher@amd.com>2017-05-24 17:40:41 -0400
commit4f059ecdcec2dd6fab757a16cc552093bfd321ee (patch)
treed7cafdf6d2d308a22af7a2fa918dd3662d8b8cb8
parent65781c78ad74e4260fbec92c0ecc05738044e177 (diff)
downloadop-kernel-dev-4f059ecdcec2dd6fab757a16cc552093bfd321ee.zip
op-kernel-dev-4f059ecdcec2dd6fab757a16cc552093bfd321ee.tar.gz
drm/amdgpu:use job's list instead of check fence
because if the fence is really signaled, it could already released so the fence pointer is a wild pointer, but if we use job->base.node we are safe because job will not be released untill amdgpu_job_timedout finished. Signed-off-by: Monk Liu <Monk.Liu@amd.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
-rw-r--r--drivers/gpu/drm/amd/amdgpu/amdgpu_device.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
index 8b0f486..d1385eb 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
@@ -2644,9 +2644,9 @@ int amdgpu_sriov_gpu_reset(struct amdgpu_device *adev, struct amdgpu_job *job)
if (job && j != i)
continue;
- /* here give the last chance to check if fence signaled
+ /* here give the last chance to check if job removed from mirror-list
* since we already pay some time on kthread_park */
- if (job && dma_fence_is_signaled(&job->base.s_fence->finished)) {
+ if (job && list_empty(&job->base.node)) {
kthread_unpark(ring->sched.thread);
goto give_up_reset;
}
OpenPOWER on IntegriCloud