diff options
| author | Brian King <brking@linux.vnet.ibm.com> | 2009-05-28 16:17:22 -0500 |
|---|---|---|
| committer | James Bottomley <James.Bottomley@HansenPartnership.com> | 2009-06-08 13:07:29 -0500 |
| commit | 4a2837d4fcaf8a2c2ad61523287073d0c14b9ed0 (patch) | |
| tree | 9c5a664d6c5b2ca63daa5907c66d6a644a0bc1e5 | |
| parent | 601e7638254c118fca135af9b1a9f35061420f62 (diff) | |
| download | op-kernel-dev-4a2837d4fcaf8a2c2ad61523287073d0c14b9ed0.zip op-kernel-dev-4a2837d4fcaf8a2c2ad61523287073d0c14b9ed0.tar.gz | |
[SCSI] ibmvfc: Fix invalid error response handling
Fix an obvious bug in processing error responses for SCSI commands
which can result in successful responses being incorrectly returned
with DID_ERROR.
Signed-off-by: Brian King <brking@linux.vnet.ibm.com>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
| -rw-r--r-- | drivers/scsi/ibmvscsi/ibmvfc.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/scsi/ibmvscsi/ibmvfc.c b/drivers/scsi/ibmvscsi/ibmvfc.c index ea4abee..879c511 100644 --- a/drivers/scsi/ibmvscsi/ibmvfc.c +++ b/drivers/scsi/ibmvscsi/ibmvfc.c @@ -275,7 +275,7 @@ static int ibmvfc_get_err_result(struct ibmvfc_cmd *vfc_cmd) int fc_rsp_len = rsp->fcp_rsp_len; if ((rsp->flags & FCP_RSP_LEN_VALID) && - ((!fc_rsp_len && fc_rsp_len != 4 && fc_rsp_len != 8) || + ((fc_rsp_len && fc_rsp_len != 4 && fc_rsp_len != 8) || rsp->data.info.rsp_code)) return DID_ERROR << 16; |
