summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorArnd Bergmann <arnd@arndb.de>2010-07-07 23:40:09 +0200
committerGreg Kroah-Hartman <gregkh@suse.de>2010-07-08 13:57:58 -0700
commit3ff81013699000f2d55e78efadb03a6e2beddb7a (patch)
tree5600c42d85ebfa7e2f10a460b11570a75f34076d
parentaf6d2b2a3d43d25aa4e205c029ee737642cc4ec2 (diff)
downloadop-kernel-dev-3ff81013699000f2d55e78efadb03a6e2beddb7a.zip
op-kernel-dev-3ff81013699000f2d55e78efadb03a6e2beddb7a.tar.gz
Staging: use llseek in all file operations
These could not be detected by the semantic patch. Signed-off-by: Arnd Bergmann <arnd@arndb.de>
-rw-r--r--drivers/staging/msm/mdp4_debugfs.c10
-rw-r--r--drivers/staging/panel/panel.c3
2 files changed, 4 insertions, 9 deletions
diff --git a/drivers/staging/msm/mdp4_debugfs.c b/drivers/staging/msm/mdp4_debugfs.c
index 844d467..36954e8 100644
--- a/drivers/staging/msm/mdp4_debugfs.c
+++ b/drivers/staging/msm/mdp4_debugfs.c
@@ -63,13 +63,6 @@ DEFINE_SIMPLE_ATTRIBUTE(
"%llx\n");
-static int mdp4_debugfs_open(struct inode *inode, struct file *file)
-{
- /* non-seekable */
- file->f_mode &= ~(FMODE_LSEEK | FMODE_PREAD | FMODE_PWRITE);
- return 0;
-}
-
static int mdp4_debugfs_release(struct inode *inode, struct file *file)
{
return 0;
@@ -144,10 +137,11 @@ static ssize_t mdp4_debugfs_read(
}
static const struct file_operations mdp4_debugfs_fops = {
- .open = mdp4_debugfs_open,
+ .open = nonseekable_open,
.release = mdp4_debugfs_release,
.read = mdp4_debugfs_read,
.write = mdp4_debugfs_write,
+ .llseek = no_llseek,
};
int mdp4_debugfs_init(void)
diff --git a/drivers/staging/panel/panel.c b/drivers/staging/panel/panel.c
index 6fa57be..8bd7182 100644
--- a/drivers/staging/panel/panel.c
+++ b/drivers/staging/panel/panel.c
@@ -1356,7 +1356,7 @@ static int lcd_open(struct inode *inode, struct file *file)
lcd_must_clear = 0;
}
lcd_open_cnt++;
- return 0;
+ return nonseekable_open(inode, file);
}
static int lcd_release(struct inode *inode, struct file *file)
@@ -1369,6 +1369,7 @@ static const struct file_operations lcd_fops = {
.write = lcd_write,
.open = lcd_open,
.release = lcd_release,
+ .llseek = no_llseek,
};
static struct miscdevice lcd_dev = {
OpenPOWER on IntegriCloud