summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAmit Shah <amit.shah@redhat.com>2013-08-07 15:54:17 +0930
committerRusty Russell <rusty@rustcorp.com.au>2013-08-09 13:02:16 +0930
commit3b868a4073cdedf395f26d843874414e0e0e9cfd (patch)
treec61396970bcaa517abe6511dda51914737a8dfd3
parent11489736177c5930514482b4db7af862d945335d (diff)
downloadop-kernel-dev-3b868a4073cdedf395f26d843874414e0e0e9cfd.zip
op-kernel-dev-3b868a4073cdedf395f26d843874414e0e0e9cfd.tar.gz
virtio: console: prevent use-after-free of port name in port unplug
Remove the debugfs path before freeing port->name, to prevent a possible use-after-free. Reported-by: Jason Wang <jasowang@redhat.com> Signed-off-by: Amit Shah <amit.shah@redhat.com> Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
-rw-r--r--drivers/char/virtio_console.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c
index d0e75aa..b79cf3e 100644
--- a/drivers/char/virtio_console.c
+++ b/drivers/char/virtio_console.c
@@ -1591,9 +1591,8 @@ static void unplug_port(struct port *port)
device_destroy(pdrvdata.class, port->dev->devt);
cdev_del(port->cdev);
- kfree(port->name);
-
debugfs_remove(port->debugfs_file);
+ kfree(port->name);
/*
* Locks around here are not necessary - a port can't be
OpenPOWER on IntegriCloud