summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@oracle.com>2014-04-03 10:21:34 +0300
committerThomas Gleixner <tglx@linutronix.de>2014-04-28 21:43:24 +0200
commit3894e9e82dfdc87fa35dc7976e0472d220228826 (patch)
treeff20bd710bb1b3f22929f19c7d53ba4f8388e50c
parent8cc3cfc5ccf1680b7c88f874912b6bec2797b76b (diff)
downloadop-kernel-dev-3894e9e82dfdc87fa35dc7976e0472d220228826.zip
op-kernel-dev-3894e9e82dfdc87fa35dc7976e0472d220228826.tar.gz
irqchip: irq-crossbar: Not allocating enough memory
We are allocating the size of a pointer and not the size of the data. This will lead to memory corruption. There isn't actually a "cb_device" struct, btw. The code is only able to compile because GCC knows that all pointers are the same size. Fixes: 96ca848ef7ea ('DRIVERS: IRQCHIP: CROSSBAR: Add support for Crossbar IP') Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Acked-by: Sricharan R <r.sricharan@ti.com> Cc: Grant Likely <grant.likely@linaro.org> Cc: Rob Herring <robh+dt@kernel.org> Link: http://lkml.kernel.org/r/20140403072134.GA14286@mwanda Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
-rw-r--r--drivers/irqchip/irq-crossbar.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/irqchip/irq-crossbar.c b/drivers/irqchip/irq-crossbar.c
index fc817d2..3d15d16 100644
--- a/drivers/irqchip/irq-crossbar.c
+++ b/drivers/irqchip/irq-crossbar.c
@@ -107,7 +107,7 @@ static int __init crossbar_of_init(struct device_node *node)
int i, size, max, reserved = 0, entry;
const __be32 *irqsr;
- cb = kzalloc(sizeof(struct cb_device *), GFP_KERNEL);
+ cb = kzalloc(sizeof(*cb), GFP_KERNEL);
if (!cb)
return -ENOMEM;
OpenPOWER on IntegriCloud