diff options
| author | Himangi Saraogi <himangi774@gmail.com> | 2014-07-20 03:19:59 +0530 |
|---|---|---|
| committer | Scott Wood <scottwood@freescale.com> | 2014-07-29 19:26:31 -0500 |
| commit | 3894817fb1df6261bbfff7d2d540510372883543 (patch) | |
| tree | 6a05787668c8976abb617faad5aed19d008d25a4 | |
| parent | 983e2444100667b4b35c9d56c9a1fec1e817143c (diff) | |
| download | op-kernel-dev-3894817fb1df6261bbfff7d2d540510372883543.zip op-kernel-dev-3894817fb1df6261bbfff7d2d540510372883543.tar.gz | |
powerpc/fsl-pci: Correct use of ! and &
In commit ae91d60ba88ef0bdb1b5e9b2363bd52fc45d2af7, a bug was fixed that
involved converting !x & y to !(x & y). The code below shows the same
pattern, and thus should perhaps be fixed in the same way.
This is not tested and clearly changes the semantics, so it is only
something to consider.
The Coccinelle semantic patch that makes this change is as follows:
// <smpl>
@@ expression E1,E2; @@
(
!E1 & !E2
|
- !E1 & E2
+ !(E1 & E2)
)
// </smpl>
Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Signed-off-by: Scott Wood <scottwood@freescale.com>
| -rw-r--r-- | arch/powerpc/sysdev/fsl_pci.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/arch/powerpc/sysdev/fsl_pci.c b/arch/powerpc/sysdev/fsl_pci.c index 4bd091a..c507767 100644 --- a/arch/powerpc/sysdev/fsl_pci.c +++ b/arch/powerpc/sysdev/fsl_pci.c @@ -853,8 +853,8 @@ u64 fsl_pci_immrbar_base(struct pci_controller *hose) in = pcie->cfg_type0 + PEX_RC_INWIN_BASE; for (i = 0; i < 4; i++) { /* not enabled, skip */ - if (!in_le32(&in[i].ar) & PEX_RCIWARn_EN) - continue; + if (!(in_le32(&in[i].ar) & PEX_RCIWARn_EN)) + continue; if (get_immrbase() == in_le32(&in[i].tar)) return (u64)in_le32(&in[i].barh) << 32 | |
