summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMaxime Ripard <maxime.ripard@free-electrons.com>2014-05-09 22:33:36 -0500
committerMaxime Ripard <maxime.ripard@free-electrons.com>2014-06-11 09:58:44 +0200
commit2c6fba1038f2b27fffe7ab0ddd42f9f283128105 (patch)
treed27cdca4191a7017f2f71828cb99e74f49018b34
parent6d1d14d5ce3e7880f91e7cfbdeca88128fe741ca (diff)
downloadop-kernel-dev-2c6fba1038f2b27fffe7ab0ddd42f9f283128105.zip
op-kernel-dev-2c6fba1038f2b27fffe7ab0ddd42f9f283128105.tar.gz
clk: sunxi: Remove calls to clk_put
Callers of clk_put must disable the clock first. This also means that as long as the clock is enabled the driver should hold a reference to that clock. Hence, the call to clk_put here are bogus and should be removed. Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com> Acked-by: Mike Turquette <mturquette@linaro.org> Signed-off-by: Emilio López <emilio@elopez.com.ar>
-rw-r--r--drivers/clk/sunxi/clk-sunxi.c8
1 files changed, 2 insertions, 6 deletions
diff --git a/drivers/clk/sunxi/clk-sunxi.c b/drivers/clk/sunxi/clk-sunxi.c
index bf5075e..9bfa21a 100644
--- a/drivers/clk/sunxi/clk-sunxi.c
+++ b/drivers/clk/sunxi/clk-sunxi.c
@@ -1339,17 +1339,13 @@ static void __init sunxi_clock_protect(void)
/* memory bus clock - sun5i+ */
clk = clk_get(NULL, "mbus");
- if (!IS_ERR(clk)) {
+ if (!IS_ERR(clk))
clk_prepare_enable(clk);
- clk_put(clk);
- }
/* DDR clock - sun4i+ */
clk = clk_get(NULL, "pll5_ddr");
- if (!IS_ERR(clk)) {
+ if (!IS_ERR(clk))
clk_prepare_enable(clk);
- clk_put(clk);
- }
}
static void __init sunxi_init_clocks(struct device_node *np)
OpenPOWER on IntegriCloud