diff options
author | Alan Cox <alan@lxorguk.ukuu.org.uk> | 2007-09-26 23:02:52 +0100 |
---|---|---|
committer | Jeff Garzik <jeff@garzik.org> | 2007-10-12 14:55:42 -0400 |
commit | 21d2c925d3da6aabf9a0b34e95787202379f682a (patch) | |
tree | ecc292c071e6d30b45e035f0e6f2ad09f79e2536 | |
parent | 3cc3eb1148e4b2dfabf7a1dcf36fd8be1331ca95 (diff) | |
download | op-kernel-dev-21d2c925d3da6aabf9a0b34e95787202379f682a.zip op-kernel-dev-21d2c925d3da6aabf9a0b34e95787202379f682a.tar.gz |
pata_atiixp: Audit notes on locking
Signed-off-by: Alan Cox <alan@redhat.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
-rw-r--r-- | drivers/ata/pata_atiixp.c | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/drivers/ata/pata_atiixp.c b/drivers/ata/pata_atiixp.c index 95ed307..9623f52 100644 --- a/drivers/ata/pata_atiixp.c +++ b/drivers/ata/pata_atiixp.c @@ -173,6 +173,9 @@ static void atiixp_set_dmamode(struct ata_port *ap, struct ata_device *adev) * * When DMA begins we need to ensure that the UDMA control * register for the channel is correctly set. + * + * Note: The host lock held by the libata layer protects + * us from two channels both trying to set DMA bits at once */ static void atiixp_bmdma_start(struct ata_queued_cmd *qc) @@ -199,6 +202,9 @@ static void atiixp_bmdma_start(struct ata_queued_cmd *qc) * * DMA has completed. Clear the UDMA flag as the next operations will * be PIO ones not UDMA data transfer. + * + * Note: The host lock held by the libata layer protects + * us from two channels both trying to set DMA bits at once */ static void atiixp_bmdma_stop(struct ata_queued_cmd *qc) |