diff options
| author | Linus Walleij <linus.walleij@linaro.org> | 2015-12-21 14:54:59 +0100 |
|---|---|---|
| committer | Linus Walleij <linus.walleij@linaro.org> | 2015-12-26 22:28:29 +0100 |
| commit | 18df16692d2ecfac1b48d2036bf4ff7200c191cd (patch) | |
| tree | 69aba8d0429e148bbe43a360a5ea9eea184d1c18 | |
| parent | 9fa90796244aa6043d59c8e127845ff9e3b01485 (diff) | |
| download | op-kernel-dev-18df16692d2ecfac1b48d2036bf4ff7200c191cd.zip op-kernel-dev-18df16692d2ecfac1b48d2036bf4ff7200c191cd.tar.gz | |
gpio: tz1090-pdc: Be sure to clamp return value
As we want gpio_chip .get() calls to be able to return negative
error codes and propagate to drivers, we need to go over all
drivers and make sure their return values are clamped to [0,1].
We do this by using the ret = !!(val) design pattern.
Acked-by: James Hogan <james.hogan@imgtec.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
| -rw-r--r-- | drivers/gpio/gpio-tz1090-pdc.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpio/gpio-tz1090-pdc.c b/drivers/gpio/gpio-tz1090-pdc.c index 0a01c87..b08b22b 100644 --- a/drivers/gpio/gpio-tz1090-pdc.c +++ b/drivers/gpio/gpio-tz1090-pdc.c @@ -113,7 +113,7 @@ static int tz1090_pdc_gpio_direction_output(struct gpio_chip *chip, static int tz1090_pdc_gpio_get(struct gpio_chip *chip, unsigned int offset) { struct tz1090_pdc_gpio *priv = to_pdc(chip); - return pdc_read(priv, REG_SOC_GPIO_STATUS) & BIT(offset); + return !!(pdc_read(priv, REG_SOC_GPIO_STATUS) & BIT(offset)); } static void tz1090_pdc_gpio_set(struct gpio_chip *chip, unsigned int offset, |
