summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorIngo Molnar <mingo@elte.hu>2008-11-25 10:27:49 +0100
committerIngo Molnar <mingo@elte.hu>2008-11-29 20:39:29 +0100
commit1583715ddb61f822041807a0f18b3b4845e88c76 (patch)
treecdc54eb7c0105197560641745059db7c20166eec
parent4cd4262034849da01eb88659af677b69f8169f06 (diff)
downloadop-kernel-dev-1583715ddb61f822041807a0f18b3b4845e88c76.zip
op-kernel-dev-1583715ddb61f822041807a0f18b3b4845e88c76.tar.gz
sched, cpusets: fix warning in kernel/cpuset.c
this warning: kernel/cpuset.c: In function ‘generate_sched_domains’: kernel/cpuset.c:588: warning: ‘ndoms’ may be used uninitialized in this function triggers because GCC does not recognize that ndoms stays uninitialized only if doms is NULL - but that flow is covered at the end of generate_sched_domains(). Help out GCC by initializing this variable to 0. (that's prudent anyway) Also, this function needs a splitup and code flow simplification: with 160 lines length it's clearly too long. Signed-off-by: Ingo Molnar <mingo@elte.hu>
-rw-r--r--kernel/cpuset.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/kernel/cpuset.c b/kernel/cpuset.c
index da7ff61..96c0ba1 100644
--- a/kernel/cpuset.c
+++ b/kernel/cpuset.c
@@ -585,7 +585,7 @@ static int generate_sched_domains(cpumask_t **domains,
int i, j, k; /* indices for partition finding loops */
cpumask_t *doms; /* resulting partition; i.e. sched domains */
struct sched_domain_attr *dattr; /* attributes for custom domains */
- int ndoms; /* number of sched domains in result */
+ int ndoms = 0; /* number of sched domains in result */
int nslot; /* next empty doms[] cpumask_t slot */
doms = NULL;
OpenPOWER on IntegriCloud