diff options
| author | Orson Zhai <orson.zhai@spreadtrum.com> | 2017-04-25 09:16:56 +0800 |
|---|---|---|
| committer | Jonathan Cameron <jic23@kernel.org> | 2017-04-27 06:30:52 +0100 |
| commit | 1016d56765740e02a613346f22a35c0ae7bccac4 (patch) | |
| tree | 131bae54792d855ccfb3e4a7ae0b0869a36959b9 | |
| parent | 80a49fd8244e810380adeacca10712c7a867d709 (diff) | |
| download | op-kernel-dev-1016d56765740e02a613346f22a35c0ae7bccac4.zip op-kernel-dev-1016d56765740e02a613346f22a35c0ae7bccac4.tar.gz | |
iio: core: Fix suspicious sizeof usage
Pointer size is variours in different system, say 32bit for 4 and 64bit
for 8. The 'sizeof(infomask)' may lead to wrong bit numbers.
Signed-off-by: Orson Zhai <orson.zhai@spreadtrum.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
| -rw-r--r-- | drivers/iio/industrialio-core.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/iio/industrialio-core.c b/drivers/iio/industrialio-core.c index 3ff91e0..795f53c 100644 --- a/drivers/iio/industrialio-core.c +++ b/drivers/iio/industrialio-core.c @@ -1089,7 +1089,7 @@ static int iio_device_add_info_mask_type(struct iio_dev *indio_dev, { int i, ret, attrcount = 0; - for_each_set_bit(i, infomask, sizeof(infomask)*8) { + for_each_set_bit(i, infomask, sizeof(*infomask)*8) { if (i >= ARRAY_SIZE(iio_chan_info_postfix)) return -EINVAL; ret = __iio_add_chan_devattr(iio_chan_info_postfix[i], @@ -1118,7 +1118,7 @@ static int iio_device_add_info_mask_type_avail(struct iio_dev *indio_dev, int i, ret, attrcount = 0; char *avail_postfix; - for_each_set_bit(i, infomask, sizeof(infomask) * 8) { + for_each_set_bit(i, infomask, sizeof(*infomask) * 8) { avail_postfix = kasprintf(GFP_KERNEL, "%s_available", iio_chan_info_postfix[i]); |
