summaryrefslogtreecommitdiffstats
path: root/.gitignore
diff options
context:
space:
mode:
authorDan Williams <dan.j.williams@intel.com>2014-03-14 13:52:48 -0700
committerTejun Heo <tj@kernel.org>2014-03-18 16:08:38 -0400
commitbc6e7c4b0d1a1f742d96556f63d68f17f4e232c3 (patch)
tree1253c9a09dc834bbb42ef02e58ee0a117ed17ff8 /.gitignore
parent6a96918a6aa7b434d15710fc9e06589c6c8bd3a6 (diff)
downloadop-kernel-dev-bc6e7c4b0d1a1f742d96556f63d68f17f4e232c3.zip
op-kernel-dev-bc6e7c4b0d1a1f742d96556f63d68f17f4e232c3.tar.gz
libata, libsas: kill pm_result and related cleanup
Tejun says: "At least for libata, worrying about suspend/resume failures don't make whole lot of sense. If suspend failed, just proceed with suspend. If the device can't be woken up afterwards, that's that. There isn't anything we could have done differently anyway. The same for resume, if spinup fails, the device is dud and the following commands will invoke EH actions and will eventually fail. Again, there really isn't any *choice* to make. Just making sure the errors are handled gracefully (ie. don't crash) and the following commands are handled correctly should be enough." The only libata user that actually cares about the result from a suspend operation is libsas. However, it only cares about whether queuing a new operation collides with an in-flight one. All libsas does with the error is retry, but we can just let libata wait for the previous operation before continuing. Other cleanups include: 1/ Unifying all ata port pm operations on an ata_port_pm_ prefix 2/ Marking all ata port pm helper routines as returning void, only ata_port_pm_ entry points need to fake a 0 return value. 3/ Killing ata_port_{suspend|resume}_common() in favor of calling ata_port_request_pm() directly 4/ Killing the wrappers that just do a to_ata_port() conversion 5/ Clearly marking the entry points that do async operations with an _async suffix. Reference: http://marc.info/?l=linux-scsi&m=138995409532286&w=2 Cc: Phillip Susi <psusi@ubuntu.com> Cc: Alan Stern <stern@rowland.harvard.edu> Suggested-by: Tejun Heo <tj@kernel.org> Signed-off-by: Todd Brandt <todd.e.brandt@intel.com> Signed-off-by: Dan Williams <dan.j.williams@intel.com> Signed-off-by: Tejun Heo <tj@kernel.org>
Diffstat (limited to '.gitignore')
0 files changed, 0 insertions, 0 deletions
OpenPOWER on IntegriCloud