summaryrefslogtreecommitdiffstats
path: root/AUTHORS
diff options
context:
space:
mode:
authordscho <dscho>2007-03-17 00:13:12 +0000
committerdscho <dscho>2007-03-17 00:13:12 +0000
commit61cd498fb21b5b2a3f63f336b1f1ed297f451c22 (patch)
treeeb244ffcad4535e554e726e0a8e229a933314215 /AUTHORS
parent9e1230c77bbcefcfb3a11466797376fa3c6167b7 (diff)
downloadlibvncserver-61cd498fb21b5b2a3f63f336b1f1ed297f451c22.zip
libvncserver-61cd498fb21b5b2a3f63f336b1f1ed297f451c22.tar.gz
Fix a locking problem in libvncserver
There seems to be a locking problem in libvncserver, with respect to how condition variables are used. On certain machines in our lab, when using a vncviewer to view a display that has a very high rate of updates, we will occasionally see the VNC server process crash. In one stack trace that was obtained, an assertion had tripped in glibc's pthread_cond_wait, which was called from clientOutput. Inspection of clientOutput suggests that WAIT is being called incorrectly. The mutex that protects a condition variable should always be locked when calling wait, and on return from the wait will still be locked. The attached patch fixes the locking around this condition variable, and one other that I found by grepping the source for similar occurrences. Signed-off-by: Charles Coffing <ccoffing@novell.com>
Diffstat (limited to 'AUTHORS')
-rw-r--r--AUTHORS2
1 files changed, 1 insertions, 1 deletions
diff --git a/AUTHORS b/AUTHORS
index d5d1a87..ab799ef 100644
--- a/AUTHORS
+++ b/AUTHORS
@@ -29,7 +29,7 @@ Oliver Mihatsch, Greg Sternberg, Werner Hofer, Giampiero Giancipoli,
Glenn Mabutt, Paul Kreiner, Erik Kunze, Mike Frysinger, Martin Waitz,
Mark McLoughlin, Paul Fox, Juan Jose Costello, Andre Leiadella,
Alberto Lusiani, Malvina Mazin, Dave Stuart, Rohit Kumar, Donald Dugger,
-Steven Carr, and Uwe Völker.
+Steven Carr, Uwe Völker, and Charles Coffing.
Probably I forgot quite a few people sending a patch here and there, which
really made a difference. Without those, some obscure bugs still would
OpenPOWER on IntegriCloud