From 92fa45f087d08de65ddc42c2b535fd81f207c5cf Mon Sep 17 00:00:00 2001 From: "Denis V. Lunev" Date: Tue, 9 Feb 2016 19:49:05 +0300 Subject: vl: fix tracing initialization MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit we should call trace_init_backends() before trace_init_file() for CONFIG_TRACE_SIMPLE There is no difference for other cases. This problem was introduced by the commit commit 41fc57e44ed64cd4ab5393d83624afd897dabd4f Author: Paolo Bonzini Date: Thu Jan 7 16:55:24 2016 +0300 trace: split trace_init_file out of trace_init_backends 'make check' was failed as a result if configured with --enable-trace-backends=simple Spotted by Alex Bennée. Signed-off-by: Denis V. Lunev Reviewed-by: Alex Bennée Tested-by: Alex Bennée Tested-by: Christian Borntraeger Message-id: 1455036545-14870-1-git-send-email-den@openvz.org CC: Alex Bennée CC: Paolo Bonzini CC: Stefan Hajnoczi Signed-off-by: Stefan Hajnoczi --- vl.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) (limited to 'vl.c') diff --git a/vl.c b/vl.c index 6fea089..f146bc5 100644 --- a/vl.c +++ b/vl.c @@ -4081,6 +4081,9 @@ int main(int argc, char **argv, char **envp) exit(0); } + if (!trace_init_backends()) { + exit(1); + } trace_init_file(trace_file); /* Open the logfile at this point and set the log mask if necessary. @@ -4101,10 +4104,6 @@ int main(int argc, char **argv, char **envp) qemu_set_log(0); } - if (!trace_init_backends()) { - exit(1); - } - /* If no data_dir is specified then try to find it relative to the executable path. */ if (data_dir_idx < ARRAY_SIZE(data_dir)) { -- cgit v1.1