From 7e79cf4083efa399b43f30edf23434b137fcb197 Mon Sep 17 00:00:00 2001 From: Yonit Halperin Date: Mon, 5 Sep 2011 17:39:50 +0300 Subject: spice: set qxl->ssd.running=true before telling spice to start, RHBZ #733993 If qxl->ssd.running=true is set after telling spice to start, the spice server thread can call qxl_send_events while qxl->ssd.running is still false. This leads to assert(d->ssd.running). Signed-off-by: Yonit Halperin Signed-off-by: Gerd Hoffmann --- ui/spice-display.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'ui/spice-display.c') diff --git a/ui/spice-display.c b/ui/spice-display.c index 4983963..e385361 100644 --- a/ui/spice-display.c +++ b/ui/spice-display.c @@ -260,11 +260,12 @@ void qemu_spice_vm_change_state_handler(void *opaque, int running, int reason) SimpleSpiceDisplay *ssd = opaque; if (running) { + ssd->running = true; qemu_spice_start(ssd); } else { qemu_spice_stop(ssd); + ssd->running = false; } - ssd->running = running; } void qemu_spice_display_init_common(SimpleSpiceDisplay *ssd, DisplayState *ds) -- cgit v1.1