From 6e0abc251dd4f8eba1f53656dfede12e5840e83b Mon Sep 17 00:00:00 2001 From: Max Reitz Date: Fri, 11 Dec 2015 16:23:05 +0100 Subject: blockdev: Mark {insert, remove}-medium experimental While in the long term we want throttling to be its own block filter BDS, in the short term we want it to be part of the BB instead of a BDS; even in the long term we may want legacy throttling to be automatically tied to the BB. blockdev-insert-medium and blockdev-remove-medium do not retain throttling information in the BB (deliberately so). Therefore, using them means tying this information to a BDS, which would break the model described above. (The same applies to other flags such as detect_zeroes.) We probably want to move this information to the BB or its own filter BDS before blockdev-{insert,remove}-medium can be considered completely stable. Therefore, mark these functions experimental for the time being. Suggested-by: Markus Armbruster Signed-off-by: Max Reitz Acked-by: Markus Armbruster Acked-by: Kevin Wolf Message-id: 1449847385-13986-2-git-send-email-mreitz@redhat.com Reviewed-by: Eric Blake [PMM: fixed format nit (underlining) in qmp-commands.hx] Signed-off-by: Peter Maydell --- qapi/block-core.json | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) (limited to 'qapi') diff --git a/qapi/block-core.json b/qapi/block-core.json index a07b13f..5a23165 100644 --- a/qapi/block-core.json +++ b/qapi/block-core.json @@ -2081,7 +2081,7 @@ 'data': { 'device': 'str' } } ## -# @blockdev-remove-medium: +# @x-blockdev-remove-medium: # # Removes a medium (a block driver state tree) from a block device. That block # device's tray must currently be open (unless there is no attached guest @@ -2089,27 +2089,33 @@ # # If the tray is open and there is no medium inserted, this will be a no-op. # +# This command is still a work in progress and is considered experimental. +# Stay away from it unless you want to help with its development. +# # @device: block device name # # Since: 2.5 ## -{ 'command': 'blockdev-remove-medium', +{ 'command': 'x-blockdev-remove-medium', 'data': { 'device': 'str' } } ## -# @blockdev-insert-medium: +# @x-blockdev-insert-medium: # # Inserts a medium (a block driver state tree) into a block device. That block # device's tray must currently be open (unless there is no attached guest # device) and there must be no medium inserted already. # +# This command is still a work in progress and is considered experimental. +# Stay away from it unless you want to help with its development. +# # @device: block device name # # @node-name: name of a node in the block driver state graph # # Since: 2.5 ## -{ 'command': 'blockdev-insert-medium', +{ 'command': 'x-blockdev-insert-medium', 'data': { 'device': 'str', 'node-name': 'str'} } @@ -2137,8 +2143,8 @@ # # Changes the medium inserted into a block device by ejecting the current medium # and loading a new image file which is inserted as the new medium (this command -# combines blockdev-open-tray, blockdev-remove-medium, blockdev-insert-medium -# and blockdev-close-tray). +# combines blockdev-open-tray, x-blockdev-remove-medium, +# x-blockdev-insert-medium and blockdev-close-tray). # # @device: block device name # -- cgit v1.1