From 8c0426aed1d2279845e6a2c3355da8b5d9926cb6 Mon Sep 17 00:00:00 2001
From: Pawit Pornkitprasan
Date: Tue, 30 Jul 2013 08:39:52 +0900
Subject: migration: don't use uninitialized variables
The qmp_migrate method uses the 'blk' and 'inc' parameter without
checking if they're valid or not (they may be uninitialized if
command is received via QMP)
Signed-off-by: Pawit Pornkitprasan
Reviewed-by: Eric Blake
Signed-off-by: Luiz Capitulino
---
migration.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
(limited to 'migration.c')
diff --git a/migration.c b/migration.c
index 3f682cd..1402fa7 100644
--- a/migration.c
+++ b/migration.c
@@ -400,8 +400,8 @@ void qmp_migrate(const char *uri, bool has_blk, bool blk,
MigrationParams params;
const char *p;
- params.blk = blk;
- params.shared = inc;
+ params.blk = has_blk && blk;
+ params.shared = has_inc && inc;
if (s->state == MIG_STATE_ACTIVE || s->state == MIG_STATE_SETUP) {
error_set(errp, QERR_MIGRATION_ACTIVE);
--
cgit v1.1