From e44089c79da29ba026d0083e1428b4e82763eeab Mon Sep 17 00:00:00 2001 From: Paolo Bonzini Date: Wed, 3 Aug 2011 10:49:04 +0200 Subject: scsi-disk: no need to call scsi_req_data on a short read In fact, if the HBA's transfer_data callback goes on with scsi_req_continue the request will be completed successfully instead of showing a failure. It can even cause a segmentation fault. An easy way to trigger it is "eject -f cd" during installation (during media test if the installer does something like that). Reviewed-by: Christoph Hellwig Signed-off-by: Paolo Bonzini Signed-off-by: Anthony Liguori --- hw/scsi-disk.c | 3 --- 1 file changed, 3 deletions(-) (limited to 'hw') diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c index fa198f9..e38d9f0 100644 --- a/hw/scsi-disk.c +++ b/hw/scsi-disk.c @@ -214,9 +214,6 @@ static int scsi_handle_rw_error(SCSIDiskReq *r, int error, int type) bdrv_mon_event(s->bs, BDRV_ACTION_STOP, is_read); vm_stop(VMSTOP_DISKFULL); } else { - if (type == SCSI_REQ_STATUS_RETRY_READ) { - scsi_req_data(&r->req, 0); - } switch (error) { case ENOMEM: scsi_command_complete(r, CHECK_CONDITION, -- cgit v1.1