From 387f4a5a7193e8f8df17d2cfc360a4067dd2d675 Mon Sep 17 00:00:00 2001 From: Aurelien Jarno Date: Tue, 15 Sep 2009 01:16:28 +0200 Subject: hw/serial: don't create a char device if none is specified When creating null devices, there is no way to ensure the unicity of the labels. Bail out with an error message instead. Signed-off-by: Aurelien Jarno --- hw/serial.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) (limited to 'hw/serial.c') diff --git a/hw/serial.c b/hw/serial.c index 6f7b30e..1f4ce77 100644 --- a/hw/serial.c +++ b/hw/serial.c @@ -712,9 +712,14 @@ static void serial_reset(void *opaque) static void serial_init_core(SerialState *s, qemu_irq irq, int baudbase, CharDriverState *chr) { + if (!chr) { + fprintf(stderr, "Can't create serial device, empty char device\n"); + exit(1); + } + s->irq = irq; s->baudbase = baudbase; - s->chr = chr ?: qemu_chr_open("null", "null", NULL); + s->chr = chr; s->modem_status_poll = qemu_new_timer(vm_clock, (QEMUTimerCB *) serial_update_msl, s); -- cgit v1.1