From 81a322d4a1b68d47908a6630bf22897a289722aa Mon Sep 17 00:00:00 2001 From: Gerd Hoffmann Date: Fri, 14 Aug 2009 10:36:05 +0200 Subject: qdev: add return value to init() callbacks. Sorry folks, but it has to be. One more of these invasive qdev patches. We have a serious design bug in the qdev interface: device init callbacks can't signal failure because the init() callback has no return value. This patch fixes it. We have already one case in-tree where this is needed: Try -device virtio-blk-pci (without drive= specified) and watch qemu segfault. This patch fixes it. With usb+scsi being converted to qdev we'll get more devices where the init callback can fail for various reasons. Signed-off-by: Gerd Hoffmann Signed-off-by: Anthony Liguori --- hw/ads7846.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'hw/ads7846.c') diff --git a/hw/ads7846.c b/hw/ads7846.c index 7d1cbc7..184b3dd 100644 --- a/hw/ads7846.c +++ b/hw/ads7846.c @@ -134,7 +134,7 @@ static int ads7846_load(QEMUFile *f, void *opaque, int version_id) return 0; } -static void ads7846_init(SSISlave *dev) +static int ads7846_init(SSISlave *dev) { ADS7846State *s = FROM_SSI_SLAVE(ADS7846State, dev); @@ -152,6 +152,7 @@ static void ads7846_init(SSISlave *dev) ads7846_int_update(s); register_savevm("ads7846", -1, 0, ads7846_save, ads7846_load, s); + return 0; } static SSISlaveInfo ads7846_info = { -- cgit v1.1