From 34ceed81f9ca31829448276dafe3d9151d66962c Mon Sep 17 00:00:00 2001 From: Fam Zheng Date: Tue, 21 Jan 2014 15:07:43 +0800 Subject: vmdk: Check for overhead when opening Report an error if file size is even smaller than metadata. Signed-off-by: Fam Zheng Signed-off-by: Kevin Wolf --- block/vmdk.c | 7 +++++++ 1 file changed, 7 insertions(+) (limited to 'block') diff --git a/block/vmdk.c b/block/vmdk.c index 599a928..74c44bd 100644 --- a/block/vmdk.c +++ b/block/vmdk.c @@ -640,6 +640,13 @@ static int vmdk_open_vmdk4(BlockDriverState *bs, if (le32_to_cpu(header.flags) & VMDK4_FLAG_RGD) { l1_backup_offset = le64_to_cpu(header.rgd_offset) << 9; } + if (bdrv_getlength(file) < + le64_to_cpu(header.grain_offset) * BDRV_SECTOR_SIZE) { + error_report("File truncated, expecting at least %lld bytes", + le64_to_cpu(header.grain_offset) * BDRV_SECTOR_SIZE); + return -EINVAL; + } + ret = vmdk_add_extent(bs, file, false, le64_to_cpu(header.capacity), le64_to_cpu(header.gd_offset) << 9, -- cgit v1.1