From ee600be6a6379697d04673fd9ab10b66732b42e1 Mon Sep 17 00:00:00 2001 From: aurel32 Date: Wed, 1 Oct 2008 22:01:37 +0000 Subject: ppc: fix crash in ppc system single step support There was a bogus case where two system debug ops get generated. This patch removes the broken system debug op. This was a left over after making some changes to correctly generate debug ops on branch operations inside gen_goto_tb(); The test case against this patch is to turn on single stepping with timers, boot a linux kernel, set a breakpoint a do_fork and in gdb execute "si 3000". Then qemu-system-ppc will fault executing a debug op, which should not have been executed. Signed-off-by: Jason Wessel Signed-off-by: Aurelien Jarno git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@5391 c046a42c-6fe2-441c-8c8c-71466251a162 --- target-ppc/translate.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/target-ppc/translate.c b/target-ppc/translate.c index 275f780..00615d1 100644 --- a/target-ppc/translate.c +++ b/target-ppc/translate.c @@ -3048,10 +3048,6 @@ static always_inline void gen_bcond (DisasContext *ctx, int type) #endif gen_op_btest_T1(ctx->nip); no_test: - if (ctx->singlestep_enabled & GDBSTUB_SINGLE_STEP) { - gen_update_nip(ctx, ctx->nip); - gen_op_debug(); - } tcg_gen_exit_tb(0); } } -- cgit v1.1