diff options
author | Markus Armbruster <armbru@redhat.com> | 2015-12-17 17:35:21 +0100 |
---|---|---|
committer | Timothy Pearson <tpearson@raptorengineering.com> | 2019-11-29 19:28:24 -0600 |
commit | 59868b202f6941616c525d6b93559324015f48d8 (patch) | |
tree | 7c812fb664e2341c9e2d3e7f52b791d63af892d9 /xen-hvm.c | |
parent | 0529d6554e13ca1da9d124808bbbf97a21700ec3 (diff) | |
download | hqemu-59868b202f6941616c525d6b93559324015f48d8.zip hqemu-59868b202f6941616c525d6b93559324015f48d8.tar.gz |
xen-hvm: Mark inappropriate error handling FIXME
Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: xen-devel@lists.xensource.com
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <1450370121-5768-14-git-send-email-armbru@redhat.com>
Diffstat (limited to 'xen-hvm.c')
-rw-r--r-- | xen-hvm.c | 7 |
1 files changed, 7 insertions, 0 deletions
@@ -240,6 +240,7 @@ static void xen_ram_init(PCMachineState *pcms, void xen_ram_alloc(ram_addr_t ram_addr, ram_addr_t size, MemoryRegion *mr) { + /* FIXME caller ram_block_add() wants error_setg() on failure */ unsigned long nr_pfn; xen_pfn_t *pfn_list; int i; @@ -1192,6 +1193,12 @@ static void xen_wakeup_notifier(Notifier *notifier, void *data) int xen_hvm_init(PCMachineState *pcms, MemoryRegion **ram_memory) { + /* + * FIXME Returns -1 without cleaning up on some errors (harmless + * as long as the caller exit()s on error), dies with hw_error() + * on others. hw_error() isn't approprate here. Should probably + * simply exit() on all errors. + */ int i, rc; xen_pfn_t ioreq_pfn; xen_pfn_t bufioreq_pfn; |