diff options
| author | Markus Armbruster <armbru@redhat.com> | 2015-12-18 16:35:08 +0100 |
|---|---|---|
| committer | Timothy Pearson <tpearson@raptorengineering.com> | 2019-11-29 19:28:24 -0600 |
| commit | f89fcbe7c2aee46cae7b45120e4389ee42f8e96c (patch) | |
| tree | 40c571feb49b6ad80fa3e4474460630242aae5e8 /util | |
| parent | 000750b0c66a3eb1a71d6f01ae39eda8f56626ad (diff) | |
| download | hqemu-f89fcbe7c2aee46cae7b45120e4389ee42f8e96c.zip hqemu-f89fcbe7c2aee46cae7b45120e4389ee42f8e96c.tar.gz | |
error: Improve documentation
While there, tighten error_append_hint()'s assertion.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <1450452927-8346-6-git-send-email-armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Diffstat (limited to 'util')
| -rw-r--r-- | util/error.c | 2 | ||||
| -rw-r--r-- | util/qemu-error.c | 8 |
2 files changed, 5 insertions, 5 deletions
diff --git a/util/error.c b/util/error.c index 9b27c45..ebfb74b 100644 --- a/util/error.c +++ b/util/error.c @@ -132,7 +132,7 @@ void error_append_hint(Error **errp, const char *fmt, ...) return; } err = *errp; - assert(err && errp != &error_abort); + assert(err && errp != &error_abort && errp != &error_fatal); if (!err->hint) { err->hint = g_string_new(NULL); diff --git a/util/qemu-error.c b/util/qemu-error.c index c1574bb..ecf5708 100644 --- a/util/qemu-error.c +++ b/util/qemu-error.c @@ -200,8 +200,8 @@ static void error_print_loc(void) bool enable_timestamp_msg; /* * Print an error message to current monitor if we have one, else to stderr. - * Format arguments like vsprintf(). The result should not contain - * newlines. + * Format arguments like vsprintf(). The resulting message should be + * a single phrase, with no newline or trailing punctuation. * Prepend the current location and append a newline. * It's wrong to call this in a QMP monitor. Use error_setg() there. */ @@ -224,8 +224,8 @@ void error_vreport(const char *fmt, va_list ap) /* * Print an error message to current monitor if we have one, else to stderr. - * Format arguments like sprintf(). The result should not contain - * newlines. + * Format arguments like sprintf(). The resulting message should be a + * single phrase, with no newline or trailing punctuation. * Prepend the current location and append a newline. * It's wrong to call this in a QMP monitor. Use error_setg() there. */ |
