diff options
author | Alberto Garcia <berto@igalia.com> | 2016-02-18 12:26:57 +0200 |
---|---|---|
committer | Timothy Pearson <tpearson@raptorengineering.com> | 2019-11-29 19:45:30 -0600 |
commit | 45a97a86738600fcb93eb1ce763a743acb630db6 (patch) | |
tree | e70faa39c5286f25989e4535a2e5d5b984ac0c32 /util | |
parent | d4d2f8a497b3c1414b9397645a72594d1765ee5d (diff) | |
download | hqemu-45a97a86738600fcb93eb1ce763a743acb630db6.zip hqemu-45a97a86738600fcb93eb1ce763a743acb630db6.tar.gz |
throttle: Make throttle_is_valid() set errp
The caller does not need to set it, and this will allow us to refactor
this function later.
Signed-off-by: Alberto Garcia <berto@igalia.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Diffstat (limited to 'util')
-rw-r--r-- | util/throttle.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/util/throttle.c b/util/throttle.c index 77010b4..9046dd8 100644 --- a/util/throttle.c +++ b/util/throttle.c @@ -287,8 +287,9 @@ bool throttle_conflicting(ThrottleConfig *cfg, Error **errp) /* check if a throttling configuration is valid * @cfg: the throttling configuration to inspect * @ret: true if valid else false + * @errp: error object */ -bool throttle_is_valid(ThrottleConfig *cfg) +bool throttle_is_valid(ThrottleConfig *cfg, Error **errp) { int i; @@ -297,6 +298,8 @@ bool throttle_is_valid(ThrottleConfig *cfg) cfg->buckets[i].max < 0 || cfg->buckets[i].avg > THROTTLE_VALUE_MAX || cfg->buckets[i].max > THROTTLE_VALUE_MAX) { + error_setg(errp, "bps/iops/max values must be within [0, %lld]", + THROTTLE_VALUE_MAX); return false; } } |