path: root/util
diff options
authorPaolo Bonzini <>2015-11-04 14:48:47 +0100
committerMichael Tokarev <>2015-11-06 15:42:38 +0300
commita2f31f180499593b5edb8ac5ab8ac1b92f0abcd4 (patch)
tree176fdc1f2a9b6726ecffd8d6c22753914e8aa51d /util
parent3ede8f699645f4ca7cdbc40d8139e5a0275b4805 (diff)
qemu-sockets: do not test path with access() before unlinking
Using access() is a time-of-check/time-of-use race condition. It is okay to use them to provide better error messages, but that is pretty much it. This is not one such case; on the other hand, access() *will* skip unlink() for a non-existent path, so ignore ENOENT return values from the unlink() system call. Signed-off-by: Paolo Bonzini <> Reviewed-by: Markus Armbruster <> Reviewed-by: Edgar E. Iglesias <> Signed-off-by: Michael Tokarev <>
Diffstat (limited to 'util')
1 files changed, 1 insertions, 2 deletions
diff --git a/util/qemu-sockets.c b/util/qemu-sockets.c
index dfe4587..5a31d16 100644
--- a/util/qemu-sockets.c
+++ b/util/qemu-sockets.c
@@ -751,8 +751,7 @@ int unix_listen_opts(QemuOpts *opts, Error **errp)
qemu_opt_set(opts, "path", un.sun_path, &error_abort);
- if ((access(un.sun_path, F_OK) == 0) &&
- unlink(un.sun_path) < 0) {
+ if (unlink(un.sun_path) < 0 && errno != ENOENT) {
error_setg_errno(errp, errno,
"Failed to unlink socket %s", un.sun_path);
goto err;
OpenPOWER on IntegriCloud