path: root/util
diff options
authorShmulik Ladkani <>2015-12-02 19:49:07 +0200
committerMichael S. Tsirkin <>2015-12-02 21:51:33 +0200
commit0560b0e97df3da43651158c799c6d889f27529c3 (patch)
tree223c7402f4a51de7d2114999a039b76746f593a1 /util
parent11380b36196c483ff5c7f800b0f7af6aa53b5657 (diff)
virtio-pci: Set the QEMU_PCI_CAP_EXPRESS capability early in its DeviceClass realize method
In 1811e64 'hw/virtio: Add PCIe capability to virtio devices', the QEMU_PCI_CAP_EXPRESS capability was added to virtio's pci_dev, within 'virtio_pci_realize' - the pci device object realization method. This occurs to late, as 'pci_qdev_realize' (DeviceClass.realize of TYPE_PCI_DEVICE) has already been called, without knowing that the device instance is indeed an "express" instance, thus allocating insufficient pci config space. As a result, device may crash upon attempt to write to the PCIE config space. Fix, by arming the QEMU_PCI_CAP_EXPRESS capability early in virtio-pci's own DeviceClass realize method. This also makes code cleaner, as 'virtio_pci_realize' may now access the 'pci_is_express' predicate when needed. Signed-off-by: Shmulik Ladkani <> Reviewed-by: Michael S. Tsirkin <> Signed-off-by: Michael S. Tsirkin <> Reviewed-by: Marcel Apfelbaum <> Tested-by: Marcel Apfelbaum <>
Diffstat (limited to 'util')
0 files changed, 0 insertions, 0 deletions
OpenPOWER on IntegriCloud