diff options
| author | Markus Armbruster <armbru@redhat.com> | 2013-08-16 15:18:30 +0200 |
|---|---|---|
| committer | Michael S. Tsirkin <mst@redhat.com> | 2013-09-28 23:49:39 +0300 |
| commit | ec2df8c10a4585ba4641ae482cf2f5f13daa810e (patch) | |
| tree | 267088957ca75a0d59ff9ae3fedfdf8224d44a43 /util/qemu-thread-win32.c | |
| parent | 4f953d2fc806f1ba6fa76f01dfd121fe7d0dc4a7 (diff) | |
| download | hqemu-ec2df8c10a4585ba4641ae482cf2f5f13daa810e.zip hqemu-ec2df8c10a4585ba4641ae482cf2f5f13daa810e.tar.gz | |
smbios: Improve diagnostics for conflicting entries
We allow either tables or fields for the same type. Makes sense,
because SeaBIOS uses fields only when no tables are present.
We do this by searching the SMBIOS blob for a previously added table
or field. Error messages look like this:
qemu-system-x86_64: -smbios type=1,serial=42: SMBIOS type 1 table already defined, cannot add field
User needs to know that "table" is defined by -smbios file=..., and
"field" by -smbios type=...
Instead of searching the blob, record additions of interest, and check
that. Simpler, and makes better error messages possible:
qemu-system-x86_64: -smbios file=smbios_type_1.bin: Can't mix file= and type= for same type
qemu-system-x86_64: -smbios type=1,serial=42,serial=99: This is the conflicting setting
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Diffstat (limited to 'util/qemu-thread-win32.c')
0 files changed, 0 insertions, 0 deletions
