diff options
| author | John Snow <jsnow@redhat.com> | 2015-10-05 12:00:55 -0400 |
|---|---|---|
| committer | John Snow <jsnow@redhat.com> | 2015-10-05 12:00:55 -0400 |
| commit | 3d937150dce20cb95cbaae99b6fd48dca4261f32 (patch) | |
| tree | c36dc547f8c832acf304213a598b12930eb760ae /tests | |
| parent | c0b520dfb8890294a9f8879f4759172900585995 (diff) | |
| download | hqemu-3d937150dce20cb95cbaae99b6fd48dca4261f32.zip hqemu-3d937150dce20cb95cbaae99b6fd48dca4261f32.tar.gz | |
qtest/ahci: fix redundant assertion
Fixes https://bugs.launchpad.net/qemu/+bug/1497711
(!ncq || (ncq && lba48)) is the same as
(!ncq || lba48).
The intention is simply: "If a command is NCQ,
it must also be LBA48."
Signed-off-by: John Snow <jsnow@redhat.com>
Message-id: 1442868929-17777-1-git-send-email-jsnow@redhat.com
Diffstat (limited to 'tests')
| -rw-r--r-- | tests/libqos/ahci.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tests/libqos/ahci.c b/tests/libqos/ahci.c index cf66b3e..adb2665 100644 --- a/tests/libqos/ahci.c +++ b/tests/libqos/ahci.c @@ -742,7 +742,7 @@ AHCICommand *ahci_command_create(uint8_t command_name) g_assert(!(props->lba28 && props->lba48)); g_assert(!(props->read && props->write)); g_assert(!props->size || props->data); - g_assert(!props->ncq || (props->ncq && props->lba48)); + g_assert(!props->ncq || props->lba48); /* Defaults and book-keeping */ cmd->props = props; |
