summaryrefslogtreecommitdiffstats
path: root/qdev-monitor.c
diff options
context:
space:
mode:
authorAmos Kong <akong@redhat.com>2014-04-16 09:57:14 +0800
committerAndreas Färber <afaerber@suse.de>2014-05-05 19:08:49 +0200
commitce0abca3e35a9f95e9edcb5d6b2910b2fcd52099 (patch)
treed1c3e5bc246a0e942935ab5db0985b6eda634d64 /qdev-monitor.c
parentfdaad4715ae9e998fd0595bedfb16fdaf0c68ccc (diff)
downloadhqemu-ce0abca3e35a9f95e9edcb5d6b2910b2fcd52099.zip
hqemu-ce0abca3e35a9f95e9edcb5d6b2910b2fcd52099.tar.gz
qdev: Fix crash by validating the object type
QEMU crashed when I try to list device parameters and the driver name is actually an available bus name. # qemu -device virtio-pci-bus,? # qemu -device virtio-bus,? # qemu -device virtio-serial-bus,? qdev-monitor.c:212:qdev_device_help: Object 0x7fd932f50620 is not an instance of type device Aborted (core dumped) We can also reproduce this bug by adding device from monitor, so it's worth to fix the crash. (qemu) device_add virtio-serial-bus qdev-monitor.c:491:qdev_device_add: Object 0x7f5e89530920 is not an instance of type device Aborted (core dumped) Cc: qemu-stable@nongnu.org Signed-off-by: Amos Kong <akong@redhat.com> Reviewed-by: Markus Armbruster <armbru@redhat.com> Signed-off-by: Andreas Färber <afaerber@suse.de>
Diffstat (limited to 'qdev-monitor.c')
-rw-r--r--qdev-monitor.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/qdev-monitor.c b/qdev-monitor.c
index 6189780..02cbe43 100644
--- a/qdev-monitor.c
+++ b/qdev-monitor.c
@@ -206,7 +206,7 @@ int qdev_device_help(QemuOpts *opts)
}
}
- if (!klass) {
+ if (!object_class_dynamic_cast(klass, TYPE_DEVICE)) {
return 0;
}
do {
OpenPOWER on IntegriCloud