diff options
| author | Laszlo Ersek <lersek@redhat.com> | 2016-02-18 20:31:00 +0100 |
|---|---|---|
| committer | Timothy Pearson <tpearson@raptorengineering.com> | 2019-11-29 19:45:59 -0600 |
| commit | 3e827f50f372e562e9639fa83eff98b0cc02d9ba (patch) | |
| tree | 45be0db1ea6799615e6f672e2680d28cae5fb61e /migration/xbzrle.c | |
| parent | 06bb5bd163832940871ab386d53fdaba66318a86 (diff) | |
| download | hqemu-3e827f50f372e562e9639fa83eff98b0cc02d9ba.zip hqemu-3e827f50f372e562e9639fa83eff98b0cc02d9ba.tar.gz | |
fw_cfg: unbreak migration compatibility for 2.4 and earlier machines
When I reviewed Marc's fw_cfg DMA patches, I completely missed that the
way we set dma_enabled would break migration.
Gerd explained the right way (see reference below): dma_enabled should be
set to true by default, and only true->false transitions should be
possible:
- when the user requests that with
-global fw_cfg_mem.dma_enabled=off
or
-global fw_cfg_io.dma_enabled=off
as appropriate for the platform,
- when HW_COMPAT_2_4 dictates it,
- when board code initializes fw_cfg without requesting DMA support.
Cc: Marc Marí <markmb@redhat.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Alexandre DERUMIER <aderumier@odiso.com>
Cc: qemu-stable@nongnu.org
Ref: http://thread.gmane.org/gmane.comp.emulators.qemu/390272/focus=391042
Ref: https://bugs.launchpad.net/qemu/+bug/1536487
Suggested-by: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Message-id: 1455823860-22268-1-git-send-email-lersek@redhat.com
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Diffstat (limited to 'migration/xbzrle.c')
0 files changed, 0 insertions, 0 deletions
