diff options
author | Alon Levy <alevy@redhat.com> | 2013-06-04 16:23:37 -0400 |
---|---|---|
committer | Michael Tokarev <mjt@tls.msk.ru> | 2013-06-12 16:04:43 +0400 |
commit | 581fe784c3adf85dc167a47a4a60fd1245a98217 (patch) | |
tree | 07cdd480b6729553903bd1a1acf70cae14ff7e28 /libcacard/vscclient.c | |
parent | e098b45386a86fecc1e573d305a240a2f4aa461d (diff) | |
download | hqemu-581fe784c3adf85dc167a47a4a60fd1245a98217.zip hqemu-581fe784c3adf85dc167a47a4a60fd1245a98217.tar.gz |
libcacard/vscclient: fix leakage of socket on error paths
Spotted by Coverity.
Signed-off-by: Alon Levy <alevy@redhat.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
Diffstat (limited to 'libcacard/vscclient.c')
-rw-r--r-- | libcacard/vscclient.c | 9 |
1 files changed, 7 insertions, 2 deletions
diff --git a/libcacard/vscclient.c b/libcacard/vscclient.c index ac23647..5180d29 100644 --- a/libcacard/vscclient.c +++ b/libcacard/vscclient.c @@ -618,18 +618,22 @@ connect_to_qemu( if (ret != 0) { /* Error */ fprintf(stderr, "getaddrinfo failed\n"); - return -1; + goto cleanup_socket; } if (connect(sock, server->ai_addr, server->ai_addrlen) < 0) { /* Error */ fprintf(stderr, "Could not connect\n"); - return -1; + goto cleanup_socket; } if (verbose) { printf("Connected (sizeof Header=%zd)!\n", sizeof(VSCMsgHeader)); } return sock; + +cleanup_socket: + closesocket(sock); + return -1; } int @@ -759,5 +763,6 @@ main( g_io_channel_unref(channel_socket); g_byte_array_unref(socket_to_send); + closesocket(sock); return 0; } |