diff options
| author | Denis V. Lunev <den@openvz.org> | 2016-02-24 11:53:38 +0300 |
|---|---|---|
| committer | Timothy Pearson <tpearson@raptorengineering.com> | 2019-11-29 19:46:49 -0600 |
| commit | 95b1f52e4e898c06ca6f522708b3d77d7e3b097b (patch) | |
| tree | b777a6c3bc3e3bb5882e005ab41d0b8cf81d76d6 /include | |
| parent | 8cc18d45ed23aa5dcb24dccb4dbc9c8951464ccc (diff) | |
| download | hqemu-95b1f52e4e898c06ca6f522708b3d77d7e3b097b.zip hqemu-95b1f52e4e898c06ca6f522708b3d77d7e3b097b.tar.gz | |
migration (ordinary): move bdrv_invalidate_cache_all of of coroutine context
There is a possibility to hit an assert in qcow2_get_specific_info that
s->qcow_version is undefined. This happens when VM in starting from
suspended state, i.e. it processes incoming migration, and in the same
time 'info block' is called.
The problem is that qcow2_invalidate_cache() closes the image and
memset()s BDRVQcowState in the middle.
The patch moves processing of bdrv_invalidate_cache_all out of
coroutine context for standard migration to avoid that.
Signed-off-by: Denis V. Lunev <den@openvz.org>
Reviewed-by: Fam Zheng <famz@redhat.com>
CC: Paolo Bonzini <pbonzini@redhat.com>
CC: Juan Quintela <quintela@redhat.com>
CC: Amit Shah <amit.shah@redhat.com>
Message-Id: <1456304019-10507-2-git-send-email-den@openvz.org>
[Amit: Fix a use-after-free bug]
Signed-off-by: Amit Shah <amit.shah@redhat.com>
Diffstat (limited to 'include')
| -rw-r--r-- | include/migration/migration.h | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/include/migration/migration.h b/include/migration/migration.h index 85b6026..ac2c12c 100644 --- a/include/migration/migration.h +++ b/include/migration/migration.h @@ -104,6 +104,8 @@ struct MigrationIncomingState { QemuMutex rp_mutex; /* We send replies from multiple threads */ void *postcopy_tmp_page; + QEMUBH *bh; + int state; /* See savevm.c */ LoadStateEntry_Head loadvm_handlers; |
