diff options
| author | Markus Armbruster <armbru@redhat.com> | 2016-03-09 12:19:37 +0100 |
|---|---|---|
| committer | Timothy Pearson <tpearson@raptorengineering.com> | 2019-11-29 19:52:21 -0600 |
| commit | 68c3c77b0d4b33d7b9a6c54a3b7c15d86e9984ad (patch) | |
| tree | 8a16ce69af13727e5538f4ef23434a45722127fa /hw | |
| parent | 2ed4c9d9e2c0c16f8e25611b6c38ed1f431de48f (diff) | |
| download | hqemu-68c3c77b0d4b33d7b9a6c54a3b7c15d86e9984ad.zip hqemu-68c3c77b0d4b33d7b9a6c54a3b7c15d86e9984ad.tar.gz | |
include/hw/hw.h: Don't include qemu-common.h
qemu-common.h should only be included by .c files. Its file comment
explains why: "No header file should depend on qemu-common.h, as this
would easily lead to circular header dependencies."
hw/hw.h includes qemu-common.h, but its users generally need only
hw_error() and qemu/module.h from it. Move the former to hw/hw.h,
include the latter there, and drop the ill-advised include.
hw/misc/cbus.c now misses hw_error(), so include hw/hw.h there.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Diffstat (limited to 'hw')
| -rw-r--r-- | hw/misc/cbus.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/hw/misc/cbus.c b/hw/misc/cbus.c index fafe070..0c207e3 100644 --- a/hw/misc/cbus.c +++ b/hw/misc/cbus.c @@ -21,7 +21,7 @@ */ #include "qemu/osdep.h" -#include "qemu-common.h" +#include "hw/hw.h" #include "hw/irq.h" #include "hw/devices.h" #include "sysemu/sysemu.h" |
