diff options
| author | Gerd Hoffmann <kraxel@redhat.com> | 2009-08-14 10:36:05 +0200 |
|---|---|---|
| committer | Anthony Liguori <aliguori@us.ibm.com> | 2009-08-27 20:43:28 -0500 |
| commit | 81a322d4a1b68d47908a6630bf22897a289722aa (patch) | |
| tree | cdca9840d0620d9e0b46d7b81c58abe04a372b78 /hw/wdt_i6300esb.c | |
| parent | 24e6f3551f3c8ea7cc7524a3e64e84beca59618f (diff) | |
| download | hqemu-81a322d4a1b68d47908a6630bf22897a289722aa.zip hqemu-81a322d4a1b68d47908a6630bf22897a289722aa.tar.gz | |
qdev: add return value to init() callbacks.
Sorry folks, but it has to be. One more of these invasive qdev patches.
We have a serious design bug in the qdev interface: device init
callbacks can't signal failure because the init() callback has no
return value. This patch fixes it.
We have already one case in-tree where this is needed:
Try -device virtio-blk-pci (without drive= specified) and watch qemu
segfault. This patch fixes it.
With usb+scsi being converted to qdev we'll get more devices where the
init callback can fail for various reasons.
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
Diffstat (limited to 'hw/wdt_i6300esb.c')
| -rw-r--r-- | hw/wdt_i6300esb.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/hw/wdt_i6300esb.c b/hw/wdt_i6300esb.c index 815dacc..6927d43 100644 --- a/hw/wdt_i6300esb.c +++ b/hw/wdt_i6300esb.c @@ -413,7 +413,7 @@ static int i6300esb_load(QEMUFile *f, void *vp, int version) return 0; } -static void i6300esb_init(PCIDevice *dev) +static int i6300esb_init(PCIDevice *dev) { I6300State *d = container_of(dev, I6300State, dev); uint8_t *pci_conf; @@ -442,6 +442,8 @@ static void i6300esb_init(PCIDevice *dev) register_savevm("i6300esb_wdt", -1, sizeof(I6300State), i6300esb_save, i6300esb_load, d); + + return 0; } static WatchdogTimerModel model = { |
