summaryrefslogtreecommitdiffstats
path: root/hw/usb-uhci.c
diff options
context:
space:
mode:
authoraliguori <aliguori@c046a42c-6fe2-441c-8c8c-71466251a162>2008-09-11 19:42:00 +0000
committeraliguori <aliguori@c046a42c-6fe2-441c-8c8c-71466251a162>2008-09-11 19:42:00 +0000
commita145ea512061fb87f492605cad3f26dbb8293c99 (patch)
treea8b3219090f17ebb21628723296c086616402914 /hw/usb-uhci.c
parentc5fdf07b807e83c6774d32c632caa3ee7fe4f1b6 (diff)
downloadhqemu-a145ea512061fb87f492605cad3f26dbb8293c99.zip
hqemu-a145ea512061fb87f492605cad3f26dbb8293c99.tar.gz
uhci: Change default transaction lifetime to 32 frames (Max Krasnyansky)
Transaction lifetime was originally set to 10 frames. That was an arbitrary number I picked without much thinking :). I'm changing that to 32 frames because things like interrupt transfers and such are scheduled at that rate. It seems like 1/32 is accepted as lowest supported rate. OHCI, for example, defines exactly 32 interrupt heads. While testing USB webcam under XP I noticed that interrupt transactions were being canceled and then resubmitted on a regular basis, which works but is a waste of CPU cycles. This change fixes that. All other devices I have are not affected. Signed-off-by: Max Krasnyansky <maxk@kernel.org> Signed-off-by: Anthony Liguori <aliguori@us.ibm.com> git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@5199 c046a42c-6fe2-441c-8c8c-71466251a162
Diffstat (limited to 'hw/usb-uhci.c')
-rw-r--r--hw/usb-uhci.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/hw/usb-uhci.c b/hw/usb-uhci.c
index 62c743d..b90cf78 100644
--- a/hw/usb-uhci.c
+++ b/hw/usb-uhci.c
@@ -781,7 +781,7 @@ static int uhci_handle_td(UHCIState *s, uint32_t addr, UHCI_TD *td, uint32_t *in
async = uhci_async_find_td(s, addr, td->token);
if (async) {
/* Already submitted */
- async->valid = 10;
+ async->valid = 32;
if (!async->done)
return 1;
OpenPOWER on IntegriCloud