summaryrefslogtreecommitdiffstats
path: root/hw/scsi
diff options
context:
space:
mode:
authorStefan Hajnoczi <stefanha@redhat.com>2015-07-30 14:16:12 +0100
committerPaolo Bonzini <pbonzini@redhat.com>2015-07-30 15:44:04 +0200
commitc85a7a0057ca454607a40cde991d495e0deec34d (patch)
tree5db3f00072feaf3f0807e1ab2827cf9f5cfc64af /hw/scsi
parent1cc933453bf2baae1feb7c8e757bdfd0ef639002 (diff)
downloadhqemu-c85a7a0057ca454607a40cde991d495e0deec34d.zip
hqemu-c85a7a0057ca454607a40cde991d495e0deec34d.tar.gz
scsi-disk: fix cmd.mode field typo
The cmd.xfer field is the data length. The cmd.mode field is the data transfer direction. scsi_handle_rw_error() was using the wrong error policy for read requests. Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com> Message-Id: <1438262173-11546-3-git-send-email-stefanha@redhat.com> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Diffstat (limited to 'hw/scsi')
-rw-r--r--hw/scsi/scsi-disk.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c
index 64f0694..73fed3f 100644
--- a/hw/scsi/scsi-disk.c
+++ b/hw/scsi/scsi-disk.c
@@ -399,7 +399,7 @@ static void scsi_read_data(SCSIRequest *req)
*/
static int scsi_handle_rw_error(SCSIDiskReq *r, int error)
{
- bool is_read = (r->req.cmd.xfer == SCSI_XFER_FROM_DEV);
+ bool is_read = (r->req.cmd.mode == SCSI_XFER_FROM_DEV);
SCSIDiskState *s = DO_UPCAST(SCSIDiskState, qdev, r->req.dev);
BlockErrorAction action = blk_get_error_action(s->qdev.conf.blk,
is_read, error);
OpenPOWER on IntegriCloud