summaryrefslogtreecommitdiffstats
path: root/hw/s390x
diff options
context:
space:
mode:
authorFrank Blaschka <blaschka@linux.vnet.ibm.com>2015-01-16 14:55:21 +0100
committerCornelia Huck <cornelia.huck@de.ibm.com>2015-02-03 13:42:40 +0100
commit5b324bbafc4fe367bd9c5bfa6cff071081fb8b0e (patch)
tree3f4fb9b6a23f23375cd71052b193eb4623390226 /hw/s390x
parentc0eb33ab5428edf85a29a4f91f64d6802b6cefaa (diff)
downloadhqemu-5b324bbafc4fe367bd9c5bfa6cff071081fb8b0e.zip
hqemu-5b324bbafc4fe367bd9c5bfa6cff071081fb8b0e.tar.gz
s390x/pci: check for invalid function handle
broken guest may provide 0 (invalid) function handle to zpci instructions. Since we use function handle 0 to indicate an empty slot in the PHB we have to add an additional check to spot this kind of error. Signed-off-by: Frank Blaschka <blaschka@linux.vnet.ibm.com> Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
Diffstat (limited to 'hw/s390x')
-rw-r--r--hw/s390x/s390-pci-bus.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/hw/s390x/s390-pci-bus.c b/hw/s390x/s390-pci-bus.c
index d25ac74..dc455a2 100644
--- a/hw/s390x/s390-pci-bus.c
+++ b/hw/s390x/s390-pci-bus.c
@@ -170,7 +170,7 @@ S390PCIBusDevice *s390_pci_find_dev_by_fh(uint32_t fh)
S390pciState *s = S390_PCI_HOST_BRIDGE(
object_resolve_path(TYPE_S390_PCI_HOST_BRIDGE, NULL));
- if (!s) {
+ if (!s || !fh) {
return NULL;
}
OpenPOWER on IntegriCloud