summaryrefslogtreecommitdiffstats
path: root/hw/s390x/css.h
diff options
context:
space:
mode:
authorCornelia Huck <cornelia.huck@de.ibm.com>2014-02-11 16:23:32 +0100
committerCornelia Huck <cornelia.huck@de.ibm.com>2014-05-07 10:17:35 +0200
commit56bf1a8e90e76701428885656743515af53f19ef (patch)
tree351fd3904ed64c91fbd947590f7d9e247595981d /hw/s390x/css.h
parentc4400206d43b6a235299c7047cca0af93269fc03 (diff)
downloadhqemu-56bf1a8e90e76701428885656743515af53f19ef.zip
hqemu-56bf1a8e90e76701428885656743515af53f19ef.tar.gz
s390x/css: Don't save orb in subchannel.
Current css code saves the operation request block (orb) in the subchannel structure for later consumption by the start function handler. This might make sense for asynchronous execution of the start function (which qemu doesn't support), but not in our case; it would even be wrong since orb contains a reference to a local variable in the base ssch handler. Let's just pass the orb through the start function call chain for ssch; for rsch, we can pass NULL as the backend function does not use any information passed via the orb there. Acked-by: Christian Borntraeger <borntraeger@de.ibm.com> Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
Diffstat (limited to 'hw/s390x/css.h')
-rw-r--r--hw/s390x/css.h1
1 files changed, 0 insertions, 1 deletions
diff --git a/hw/s390x/css.h b/hw/s390x/css.h
index e9b4405..220169e 100644
--- a/hw/s390x/css.h
+++ b/hw/s390x/css.h
@@ -76,7 +76,6 @@ struct SubchDev {
hwaddr channel_prog;
CCW1 last_cmd;
bool last_cmd_valid;
- ORB *orb;
bool thinint_active;
/* transport-provided data: */
int (*ccw_cb) (SubchDev *, CCW1);
OpenPOWER on IntegriCloud