diff options
author | Markus Armbruster <armbru@redhat.com> | 2013-02-08 21:22:16 +0100 |
---|---|---|
committer | Anthony Liguori <aliguori@us.ibm.com> | 2013-02-11 08:13:19 -0600 |
commit | 312fd5f29097890179793d8bbb59ab18afbe0ad4 (patch) | |
tree | 06b08cae96d4ce9d2c1e01fe1cef2a7f7ebc0b12 /hw/qdev.c | |
parent | 1a9522cc6ea04968e1169f0195952d0029d5dbb9 (diff) | |
download | hqemu-312fd5f29097890179793d8bbb59ab18afbe0ad4.zip hqemu-312fd5f29097890179793d8bbb59ab18afbe0ad4.tar.gz |
error: Strip trailing '\n' from error string arguments (again)
Commit 6daf194d and be62a2eb got rid of a bunch, but they keep coming
back. Tracked down with this Coccinelle semantic patch:
@r@
expression err, eno, cls, fmt;
position p;
@@
(
error_report(fmt, ...)@p
|
error_set(err, cls, fmt, ...)@p
|
error_set_errno(err, eno, cls, fmt, ...)@p
|
error_setg(err, fmt, ...)@p
|
error_setg_errno(err, eno, fmt, ...)@p
)
@script:python@
fmt << r.fmt;
p << r.p;
@@
if "\\n" in str(fmt):
print "%s:%s:%s:%s" % (p[0].file, p[0].line, p[0].column, fmt)
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-id: 1360354939-10994-4-git-send-email-armbru@redhat.com
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
Diffstat (limited to 'hw/qdev.c')
-rw-r--r-- | hw/qdev.c | 4 |
1 files changed, 2 insertions, 2 deletions
@@ -114,11 +114,11 @@ DeviceState *qdev_create(BusState *bus, const char *name) dev = qdev_try_create(bus, name); if (!dev) { if (bus) { - error_report("Unknown device '%s' for bus '%s'\n", name, + error_report("Unknown device '%s' for bus '%s'", name, object_get_typename(OBJECT(bus))); abort(); } else { - error_report("Unknown device '%s' for default sysbus\n", name); + error_report("Unknown device '%s' for default sysbus", name); abort(); } } |