diff options
| author | Markus Armbruster <armbru@redhat.com> | 2016-03-09 13:44:19 +0100 |
|---|---|---|
| committer | Timothy Pearson <tpearson@raptorengineering.com> | 2019-11-29 19:52:21 -0600 |
| commit | 5d77b17f99811f60c0a5f64d32dad76768d5cee8 (patch) | |
| tree | 76ebf02e8ad052dc845933e341a4b4b450c4724b /hw/core/qdev-properties.c | |
| parent | 68c3c77b0d4b33d7b9a6c54a3b7c15d86e9984ad (diff) | |
| download | hqemu-5d77b17f99811f60c0a5f64d32dad76768d5cee8.zip hqemu-5d77b17f99811f60c0a5f64d32dad76768d5cee8.tar.gz | |
hw/pci/pci.h: Don't include qemu-common.h
qemu-common.h should only be included by .c files. Its file comment
explains why: "No header file should depend on qemu-common.h, as this
would easily lead to circular header dependencies."
hw/pci/pci.h includes qemu-common.h, but its users only need pcibus_t
and PCIHostDeviceAddress from it. Move them to hw/pci/pci.h and drop
the ill-advised include. Include hw/pci/pci.h where the moved stuff
is now missing. Except we can't in target-i386/kvm_i386.h, because
that would break the i386-linux-user compile. Add
PCIHostDeviceAddress to qemu/typedefs.h instead.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Diffstat (limited to 'hw/core/qdev-properties.c')
| -rw-r--r-- | hw/core/qdev-properties.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/hw/core/qdev-properties.c b/hw/core/qdev-properties.c index 195012c..737d29c 100644 --- a/hw/core/qdev-properties.c +++ b/hw/core/qdev-properties.c @@ -2,6 +2,7 @@ #include "net/net.h" #include "hw/qdev.h" #include "qapi/error.h" +#include "hw/pci/pci.h" #include "qapi/qmp/qerror.h" #include "qemu/error-report.h" #include "sysemu/block-backend.h" |
