diff options
author | Eric Blake <eblake@redhat.com> | 2016-01-29 06:48:42 -0700 |
---|---|---|
committer | Timothy Pearson <tpearson@raptorengineering.com> | 2019-11-29 19:31:49 -0600 |
commit | 9fb993646cda5f09ac2b35f22753a474c0ca6d62 (patch) | |
tree | 2b58e03854eede6f99591fd08d10b37e19fd444b /hmp.c | |
parent | 287a3754830577cb2c9cead09a37f5c3d0f00f46 (diff) | |
download | hqemu-9fb993646cda5f09ac2b35f22753a474c0ca6d62.zip hqemu-9fb993646cda5f09ac2b35f22753a474c0ca6d62.tar.gz |
hmp: Drop pointless allocation during qapi visit
The qapi visitor contract allows us to visit a virtual structure,
where we don't have any corresponding qapi struct. Most such uses
pass NULL for @obj; but these two callers were passing a dummy
pointer, which then gets allocated to heap memory but then
immediately freed without use. Clean this up to suppress unwanted
allocation, like we do elsewhere.
Signed-off-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <1454075341-13658-7-git-send-email-eblake@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Diffstat (limited to 'hmp.c')
-rw-r--r-- | hmp.c | 4 |
1 files changed, 1 insertions, 3 deletions
@@ -1657,7 +1657,6 @@ void hmp_object_add(Monitor *mon, const QDict *qdict) QemuOpts *opts; char *type = NULL; char *id = NULL; - void *dummy = NULL; OptsVisitor *ov; QDict *pdict; @@ -1669,7 +1668,7 @@ void hmp_object_add(Monitor *mon, const QDict *qdict) ov = opts_visitor_new(opts); pdict = qdict_clone_shallow(qdict); - visit_start_struct(opts_get_visitor(ov), &dummy, NULL, NULL, 0, &err); + visit_start_struct(opts_get_visitor(ov), NULL, NULL, NULL, 0, &err); if (err) { goto out_clean; } @@ -1701,7 +1700,6 @@ out_clean: qemu_opts_del(opts); g_free(id); g_free(type); - g_free(dummy); out: hmp_handle_error(mon, &err); |