diff options
author | Tyler Hall <tylerwhall@gmail.com> | 2012-07-25 18:45:03 -0400 |
---|---|---|
committer | Stefan Hajnoczi <stefanha@linux.vnet.ibm.com> | 2012-08-03 14:25:22 +0100 |
commit | adb2a9b5d4d5170f0b58b9f92f816048f6b8932b (patch) | |
tree | 46fb2c31f99563b7c13c558f04c5f44cfe33fbed /exec.c | |
parent | 8715fc1e4caee09bde28f8e6844ad1a3bfe52f0e (diff) | |
download | hqemu-adb2a9b5d4d5170f0b58b9f92f816048f6b8932b.zip hqemu-adb2a9b5d4d5170f0b58b9f92f816048f6b8932b.tar.gz |
exec.c: Fix off-by-one error in register_subpage
subpage_register() expects "end" to be the last byte in the mapping.
Registering a non-page-aligned memory region that extends up to or
beyond a page boundary causes subpage_register() to silently fail
through the (end >= PAGE_SIZE) check.
This bug does not cause noticeable problems for mappings that do not
extend to a page boundary, though they do register an extra byte.
Signed-off-by: Tyler Hall <tylerwhall@gmail.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Avi Kivity <avi@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Diffstat (limited to 'exec.c')
-rw-r--r-- | exec.c | 2 |
1 files changed, 1 insertions, 1 deletions
@@ -2271,7 +2271,7 @@ static void register_subpage(MemoryRegionSection *section) subpage = container_of(existing->mr, subpage_t, iomem); } start = section->offset_within_address_space & ~TARGET_PAGE_MASK; - end = start + section->size; + end = start + section->size - 1; subpage_register(subpage, start, end, phys_section_add(section)); } |